Skip to content

Bugfix: changed elapsed_time from ms to us #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

eduard-daily
Copy link

Team,

I just found out, that in custom query "Example for top 15 longest running queries", there is a value "total_elapsed_time AS [duration_total_ms]", which is being used as duration(in milliseconds).

However, the Microsoft documentation says, that total_elapsed_time from sys.dm_exec_query_stats table is being reported in microseconds, no milliseconds.

Quote from documentation:
"Total elapsed time, reported in microseconds (but only accurate to milliseconds), for completed executions of this plan."

MS doc link: https://learn.microsoft.com/en-us/sql/relational-databases/system-dynamic-management-views/sys-dm-exec-query-stats-transact-sql?view=sql-server-ver16

I believe, to avoid confusion for the NewRelic users, it would make sense to rename the fields and replace the time suffix from 'ms' to 'us'(which means microseconds).

Thanks,
Eduard

@eduard-daily eduard-daily requested a review from a team as a code owner April 3, 2025 12:29
@CLAassistant
Copy link

CLAassistant commented Apr 3, 2025

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants