Bugfix: changed elapsed_time from ms to us #216
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Team,
I just found out, that in custom query "Example for top 15 longest running queries", there is a value "total_elapsed_time AS [duration_total_ms]", which is being used as duration(in milliseconds).
However, the Microsoft documentation says, that total_elapsed_time from sys.dm_exec_query_stats table is being reported in microseconds, no milliseconds.
Quote from documentation:
"Total elapsed time, reported in microseconds (but only accurate to milliseconds), for completed executions of this plan."
MS doc link: https://learn.microsoft.com/en-us/sql/relational-databases/system-dynamic-management-views/sys-dm-exec-query-stats-transact-sql?view=sql-server-ver16
I believe, to avoid confusion for the NewRelic users, it would make sense to rename the fields and replace the time suffix from 'ms' to 'us'(which means microseconds).
Thanks,
Eduard