fix: io stalls query #240
Merged
fix: io stalls query #240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rahulreddy15
force-pushed
the
NR-426233-Investigate-and-fix-query-used-to-retrieve-io.stallInMilliseconds
branch
from
2c97fc1 to
4c7b8d8
Compare
sairaj18
reviewed
Jul 1, 2025
src/testdata/azureSQLDatabaseMetricsWithoutMemoryMetrics.json.golden
Outdated
Show resolved
Hide resolved
rahulreddy15
force-pushed
the
NR-426233-Investigate-and-fix-query-used-to-retrieve-io.stallInMilliseconds
branch
from
5c434b8 to
55c8b6a
Compare
sairaj18
reviewed
Jul 4, 2025
rahulreddy15
deleted the
NR-426233-Investigate-and-fix-query-used-to-retrieve-io.stallInMilliseconds
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects the IO stall calculation in the database performance query.
The previous implementation incorrectly added io_stall_write_ms (milliseconds) and num_of_writes (count), which mixed incompatible units and produced meaningless results.
The fix uses SUM(io_stall) instead, which properly measures total I/O wait time in consistent millisecond units. The io_stall column already aggregates all I/O stall time (reads and writes) and provides an accurate measure of I/O performance impact