Fix crash when filtering unrelated histories by refs #330
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a sort of weird condition.
Consider repository
main-repo
, into which, at some point, another repositoryside-repo
was merged via--allow-unrelated-histories
.main-repo
now has two root commits and two histories that converge at some point.Next, pick a commit from
side-repo
's own history, tag it withside-tag
for convenience.If you want to filter by
--refs=side-tag..HEAD
, for example, i.e., the selection starts insideside-repo
's history, then the output fromfast-export
is not sorted ideally. I forget the details right now, it made sense at the time ... in any case, the result is that an entry inparents
can be an untranslated commit hash instead of ID.So line 3461 will fail because
ID_TO_HASH[parent]
does not exist.Fortunately we don't actually care because
get_file_changes
wants a commit hash, so it's sufficient to use the raw entry.