Treat frontend_cid cookie like frontend with vcl_fix #1360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are various issues / stack exchange posts about "add to basket" buttons not working the first time someone presses them when using the vcl_fix method and running with an https insecure_base_url via say nginx:443->varnish->nginx. These issues are happening because magento is sending a second cookie, frontend_cid, under this configuration. The value of frontend_cid is kept in $_SESSION and the cookie is validated when the session is started. This patch adds the frontend_cid cookie to hash_data on esi private access the same as frontend cookie and appears to work. NOTES: - I haven't worried about the case when not using vcl_fix - X-Varnish-Set-Cookie shows frontend_cid for me, as beresp only sends one cookie
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are various issues / stack exchange posts about "add to basket"
buttons not working the first time someone presses them when using the vcl_fix
method and running with an https insecure_base_url via say
nginx:443->varnish->nginx.
These issues are happening because magento is sending a second
cookie, frontend_cid, under this configuration. The value of
frontend_cid is kept in $_SESSION and the cookie is validated when the
session is started.
This patch adds the frontend_cid cookie to hash_data on esi private
access the same as frontend cookie and appears to work.
NOTES: