Adminhtml cachecontroller not in use (XML missing) #1539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was introduced in nexcess#817, but this conflicted with the existing controller. This conflict was identified in nexcess#821 and resolved in nexcess#823 by removing this line. Without this line, the overridden controller is not used (and therefore the protection it adds is not being applied). This change reintroduces the required configuration in a non-conflicting way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The XML required for the core cache-controller override was introduced in #817, but this conflicted with the existing Turpentine controllers (duplicate XML node name). This conflict was identified in #821 and resolved in #823 by removing this line. Without this line, the overridden controller is not used (and therefore the protection it adds is not being applied).
This change reintroduces the required configuration in a non-conflicting way.
Because of this omission, it is possible for a site to be in a broken state (by mass enabling both turpentine & full_page caches at the same time). The second commit automatically resolves this issue when an administrator browses to the 'cache management' page. (Note that it's still possible to put a site into a problem state via command line, however with this second commit this too will be resolved automatically.)
I can split this into two separate pull requests if you'd prefer.