๐ 3๋จ๊ณ - ์ฌ๋ค๋ฆฌ(๊ฒ์ ์คํ) #2392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wheejuni
requested changes
Apr 18, 2025
Comment on lines
+24
to
+25
| Line(List<Boolean> points) { | ||
| this.points = points; |
There was a problem hiding this comment.
์ ๊ทผ ์ ์ด์ ์ ์ ํ ๋ถ์ฌํด์ฃผ์ธ์.
์ ์๊ฐ์๋ ์์ public์ผ๋ก ์์ฑํ์ ์์ฑ์๋ฅผ builder๋ static of pattern์ผ๋ก ๋ฐ๊พธ๊ณ ์ด ์์ฑ์๋ฅผ private์ผ๋ก ๊ฐ๋ฆฌ๋ ๊ฒ๋ ์ํธํ ๊ฒ ๊ฐ์ต๋๋ค.
There was a problem hiding this comment.
๋๋ค Lines์ test์ฝ๋์์๋ง ์ ๊ทผํ๋๊น default๋ก ์ ์ธํ๊ณ
builder๋ static of๋ ๊ฐ์ธ์ ์ผ๋ก ์ด์ ๋ ๋ถ๋์๋ ์ฌ์ฉ์ํ๋ ์ฃผ์์ฌ์ ์ฌ์ฉํ์ง ์์์ต๋๋ค.
์ถํ ๋ณ์๊ฐ ๋์ด๋๊ฑฐ๋ ๋ก์ง์ด ๋์ด๋๋ฉด ๋ฐ์์ ํ๋๋ก ํ๊ฒ ์ต๋๋ค!
wheejuni
approved these changes
Apr 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
๋ฆฌ๋ทฐ ๊ฐ์ฌํฉ๋๋ค!