-
Notifications
You must be signed in to change notification settings - Fork 420
Step 5 - Car racing(Refactoring) #1816
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
AparnaPattathil
wants to merge
24
commits into
next-step:aparnapattathil
Choose a base branch
from
AparnaPattathil:AparnaPattathil-step-5
base: aparnapattathil
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 1 commit
Commits
Show all changes
24 commits
Select commit
Hold shift + click to select a range
c7cec37
update readme
AparnaPattathil e00f3c7
move person to a separate package
AparnaPattathil fec28f3
move operator related functions to Operator class
AparnaPattathil 8273b5f
use require instead of throwing exceptions
AparnaPattathil 9646e45
delete gitkeep
AparnaPattathil 445215e
docs - update readme
AparnaPattathil c974519
feat - implement car racing
AparnaPattathil 5f89321
test - added unit tests
AparnaPattathil 99083f0
style - run detekt
AparnaPattathil 9d89940
refactor - use more constant values
AparnaPattathil 47e1620
step3: moving validation to init block
aparna-pattathil aef3dce
step3: views into separate package
aparna-pattathil a66de49
step3: extract car generation resposibility from CarRace class
aparna-pattathil ce081f0
step3: extract random number generation responsibility from CarRace c…
aparna-pattathil 67f09a7
step4: update readme
aparna-pattathil 2ad675d
step4: refactor to accept input as strings
aparna-pattathil 60d096c
step4: find winner and display
aparna-pattathil 6b6506a
step4: test for winner logic
aparna-pattathil 8d08560
Merge branch 'aparnapattathil' into AparnaPattathil-step-4
AparnaPattathil 6491ac2
step5: delete duplicated view after merge
aparna-pattathil bab40a5
step5: update readme
aparna-pattathil e1c490c
step5: Refactor CarRace to only focus on contolling the race flow
aparna-pattathil b46b0cd
step5: Refactor winner logic
aparna-pattathil 1c148a7
Merge branch 'aparnapattathil' into AparnaPattathil-step-5
AparnaPattathil File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Continued with #1813 (comment)
Yes, That's right!
Just a thought: what would change if RaceHistory were its own class rather than a typealias?
Would it give you more flexibility in handling race data or expressing domain logic more clearly?