feat: removing local typping #366
Closed
jarrodek wants to merge 2 commits intonextapps-de:masterfrom
jarrodek:master
Closed
feat: removing local typping #366jarrodek wants to merge 2 commits intonextapps-de:masterfrom jarrodek:master
jarrodek wants to merge 2 commits intonextapps-de:masterfrom
jarrodek:master
Conversation
Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>
Signed-off-by: Pawel Psztyc <jarrodek@gmail.com>
|
FYI: #364 is adding the @types/flexsearch types inside the project |
Contributor
|
While this library could a lot of improvements, IMHO, in this case "perfection is the enemy" just because the typings that this version is emitting are not correct, which makes this unusable for TypeScript developers. Please, consider merging this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per discussion: #266 (comment), I removed the local typings in favor of
@types/flexsearch.Motivation
The
index.d.tsfile has an outdated or incorrect types definition. This makes it useless in actual TS projects. Because there is a better types definition in the@types/flexsearchthis PR removes local types from the package.Hopefully, this can be merged very quickly. Current typings are really bad and TS project authors have to do some additional setup to make the library work in a TS projects.