Improve nginx reverse proxy template #5750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
based on (not identical): https://ssl-config.mozilla.org/#server=nginx&version=1.27.3&config=intermediate&openssl=3.4.0&hsts=false&ocsp=false&guideline=5.7 Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
|
I dropped the OCSP part, because Let's encrypt will drop support for it and nginx has no good implementation on its own (with external tools it would be good) |
szaimen
added
3. to review
36 tasks
Zoey2936
commented
Dec 16, 2024
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Signed-off-by: Zoey <[email protected]>
Zoey2936
commented
Dec 17, 2024
Signed-off-by: Zoey <[email protected]>
|
@Zoey2936 is this ready? :) |
|
Yes |
szaimen
approved these changes
Dec 17, 2024
|
|
||
| server_name <your-nc-domain>; | ||
|
|
||
| location / { | ||
| proxy_pass http://127.0.0.1:11000$request_uri; | ||
| proxy_pass http://127.0.0.1:11000$request_uri; # adjust to match APACHE_PORT and APACHE_IP_BINDING |
There was a problem hiding this comment.
Good idea! Should we maybe add this comment for the others as well?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on (not identical): https://ssl-config.mozilla.org/#server=nginx&version=1.27.3&config=intermediate&openssl=3.4.0&hsts=false&ocsp=false&guideline=5.7