aio-interface: allow to manage the community containers via the AIO interface #6443
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 tasks
szaimen
force-pushed
the
enh/5937/manage-cc-via-interface
branch
from
6f7d82a to
2ab678d
Compare
|
I propose a solution |
docjyJ
force-pushed
the
enh/5937/manage-cc-via-interface
branch
2 times, most recently
from
bc16130 to
c28f517
Compare
szaimen
commented
May 27, 2025
…nterface Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Simon L. <[email protected]>
szaimen
force-pushed
the
enh/5937/manage-cc-via-interface
branch
from
2f21ea6 to
205b18c
Compare
szaimen
commented
May 27, 2025
…e details Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
szaimen
commented
May 28, 2025
Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
|
I fixed some errors on js and renamed all variables to harmonized |
Signed-off-by: Jean-Yves <[email protected]>
docjyJ
added
3. to review
There was a problem hiding this comment.
Pull Request Overview
This pull request removes the legacy environment-variable–based management of community containers and introduces a web interface for managing them. Key changes include:
- Removal of tests and startup checks for AIO_COMMUNITY_CONTAINERS.
- Addition of new twig templates and JavaScript to support community container management via the UI.
- New functions and classes in the PHP backend to list and update community container configurations.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/QA/060-environmental-variables.md | Removed outdated test case for AIO_COMMUNITY_CONTAINERS environment var. |
| php/templates/includes/optional-containers.twig | Updated container form and description to remove community container details. |
| php/templates/includes/community-containers.twig | Introduced new template to display and manage community containers. |
| php/templates/containers.twig | Included the new community container template and added corresponding JS. |
| php/src/Data/ConfigurationManager.php | Updated community container config access and added listing/updating functions. |
| php/src/Controller/ConfigurationController.php | Added handling for community container form submission. |
| php/src/Container/CommunityContainer.php | Added new class representing a community container. |
| php/public/containers-form-submit.js | Introduced new JS to handle state changes on both container forms. |
| php/public/index.php | Passed community container data to the view. |
| php/psalm.xml & php/psalm-baseline.xml | Updated psalm configurations. |
| compose.yaml | Removed legacy comment regarding community container env var. |
| community-containers/readme.md | Updated documentation to reflect UI-based management. |
| Containers/mastercontainer/start.sh | Removed legacy environment checks for community containers. |
Co-authored-by: Copilot <[email protected]> Signed-off-by: Jean-Yves <[email protected]>
|
I saw the review button by copilot, I wanted to test it, it's not bad |
Signed-off-by: Simon L. <[email protected]>
|
Thanks @docjyJ! :) Can you please check my last commit if that makes sense? Also it looks like psalm is still not happy... |
Signed-off-by: Jean-Yves <[email protected]>
docjyJ
force-pushed
the
enh/5937/manage-cc-via-interface
branch
from
22e977c to
185d3ba
Compare
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
Signed-off-by: Jean-Yves <[email protected]>
|
LGTM |
szaimen
commented
May 28, 2025
Signed-off-by: Simon L. <[email protected]>
Signed-off-by: Simon L. <[email protected]>
docjyJ
approved these changes
May 28, 2025
Signed-off-by: Simon L. <[email protected]> Co-authored-by: Jean-Yves <[email protected]> Signed-off-by: Simon L. <[email protected]>
|
@docjyJ I just built a new develop tag and fixed some small issues but it looks like no community containers are shown in the AIO interface: |
|
Found a fix in #6473 |
|
This is now released with v11.0.0 Beta. Testing and feedback is welcome! See https://github.com/nextcloud/all-in-one#how-to-switch-the-channel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #5937