BugFix - CalendarImportWork

[alperozturk96]

• Tests written, or not not needed

Changes

Previously, if any calendar source import job failed, it caused the entire calendar event import to fail.

The visibility logic for the date picker, which was previously tied only to contactsBackupFolder, has been extended to also consider calendarBackupFolderPath.

Duplicated code has been extracted into a new getBackupFiles() method.

The legacy AsyncTask implementation has been replaced with Kotlin Coroutines.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 14 lines in your changes missing coverage. Please review.

Project coverage is 24.24%. Comparing base (0cdbc00) to head (a631445).

Files with missing lines	Patch %	Lines
...va/com/nextcloud/client/jobs/CalendarImportWork.kt	0.00%	14 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##             master   #14757      +/-   ##
============================================
+ Coverage     24.23%   24.24%   +0.01%     
- Complexity     3333     3334       +1     
============================================
  Files           700      700              
  Lines         51340    51350      +10     
  Branches       6928     6931       +3     
============================================
+ Hits          12443    12451       +8     
  Misses        36955    36955              
- Partials       1942     1944       +2     

Files with missing lines	Coverage Δ
...va/com/nextcloud/client/jobs/CalendarImportWork.kt	0.00% <0.00%> (ø)

... and 8 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[alperozturk96]

@tobiasKaminsky

Why is only contactsBackupFolder being used in this case? We also have a calendarBackupFolder, so shouldn't we be checking for the existence of both?

Additionally, how is it that refreshing the contents of the contactsBackupFolder results in calendar backups appearing as well? With the new implementation, I can now see both calendars and contacts, but I’d like to understand the reasoning behind this behavior.

[tobiasKaminsky]

Why is only contactsBackupFolder being used in this case? We also have a calendarBackupFolder, so shouldn't we be checking for the existence of both?

Indeed, we should.

Additionally, how is it that refreshing the contents of the contactsBackupFolder results in calendar backups appearing as well? With the new implementation, I can now see both calendars and contacts, but I’d like to understand the reasoning behind this behavior.

Both folders are updated within onDateSet and openDate.

[tobiasKaminsky]

Test also on master to check if the import works

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14757.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14757-Screenshot-blue-Light-15-24