Skip to content

Do not fetch shares during folder refresh #14989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 26 commits into
base: master
Choose a base branch
from
Open

Do not fetch shares during folder refresh #14989

wants to merge 26 commits into from

Conversation

alperozturk96
Copy link
Collaborator

@alperozturk96 alperozturk96 commented Jun 11, 2025 •
edited
Loading

  • Tests written, or not not needed

Library PR: nextcloud/android-library#1741

Issue: nextcloud/files-clients#97

Screenshot 2025-06-12 at 10 09 15
Screenshot_20250612_100933

@alperozturk96 alperozturk96 mentioned this pull request Jun 12, 2025
Merged
@alperozturk96 alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from c7f5e37 to 04cca36 Compare June 12, 2025 08:20
@alperozturk96 alperozturk96 mentioned this pull request Jun 12, 2025
Open
ZetaTom
ZetaTom reviewed Jun 12, 2025
View reviewed changes
@alperozturk96 alperozturk96 removed the request for review from mpivchev June 12, 2025 13:37
@alperozturk96 alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from 04cca36 to df32926 Compare June 12, 2025 13:38
@alperozturk96 alperozturk96 requested a review from ZetaTom June 12, 2025 13:39
ZetaTom

This comment was marked as resolved.

Sign in to view

@alperozturk96 alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from a7d1bee to 29cc7d0 Compare June 13, 2025 07:00
@alperozturk96 alperozturk96 requested a review from ZetaTom June 13, 2025 07:52
@alperozturk96
Copy link
Collaborator Author

@tobiasKaminsky Do we still need this?

RefreshFolderOperation#L281

if (!mSyncFullAccount) {
    sendLocalBroadcast(EVENT_SINGLE_FOLDER_SHARES_SYNCED, mLocalFolder.getRemotePath(), result);
}

@nextcloud nextcloud deleted a comment from github-actions bot Jun 13, 2025
@alperozturk96 alperozturk96 added the ux-enhancement Improvements that refine user interactions, accessibility, or overall usability label Jun 13, 2025
@nextcloud nextcloud deleted a comment from github-actions bot Jun 13, 2025
@alperozturk96 alperozturk96 added the performance 🚀 Performance improvement opportunities (non-crash related) label Jun 13, 2025
@alperozturk96 alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from e75cc04 to 39cac1a Compare June 18, 2025 06:56
@alperozturk96 alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch 2 times, most recently from 7d332d6 to 8cc61ea Compare July 3, 2025 07:29
@tobiasKaminsky
Copy link
Member

/backport to stable-3.32

@alperozturk96 alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from 8cc61ea to 9d8eb95 Compare July 18, 2025 07:06
@alperozturk96
add createContentValueForRemoteFile
1eb6636 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
add createContentValueForRemoteFile
28d9930 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
refreshSharesForFolder in share details
41abf1d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix wrong usages
9d0e17c 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix wrong usages
e909c15 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
use lib
5fa540b 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
remove unused func
d937ebb 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix kt spotless
5c67e4f 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
implement feedbacks
0b099a5 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
indicate parameters
41d55bc 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix FileDownloadLimit crash
906f9cd 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
setDownloadLimitToContentValues
4935172 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
support avatar generation for external shares
46b33d0 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix operation creation from remotefile object
4bc8de4 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix operation creation from remotefile object
cd92dce 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix ss test, pass correct argument
93f0d76 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
check token NPE
01267e6 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
listen completions of the remote operation
d5fedfd 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
add shimmering
f6b5f1d 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
add share_list_item_shimmer.xml
6f6c575 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
add blink animation
1bf6d2a 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
kt spotless fix
6d6d5b3 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
extract layouts
0f8f9f7 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix git conflict
fbcdc89 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix git conflict
dff5388 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96
fix kt spotless
39609ff 
Signed-off-by: alperozturk <[email protected]>
@alperozturk96 alperozturk96 force-pushed the do-not-fetch-shares-during-folder-refresh branch from a5e78c9 to 39609ff Compare July 23, 2025 14:32
@github-actions GitHub Actions
Copy link

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/14989.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

@github-actions GitHub Actions
Copy link

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/14989-Screenshot-blue-Light-14-45

@github-actions GitHub Actions
Copy link

Codacy

Lint

TypemasterPR
Warnings4848
Errors1111

SpotBugs

CategoryBaseNew
Bad practice6262
Correctness6161
Dodgy code299297
Experimental11
Internationalization77
Malicious code vulnerability22
Multithreaded correctness3535
Performance4850
Security1818
Total533533

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasKaminsky tobiasKaminsky tobiasKaminsky approved these changes

@ZetaTom ZetaTom Awaiting requested review from ZetaTom

Assignees
No one assigned
Labels
3. to review backport-request performance 🚀 Performance improvement opportunities (non-crash related) ux-enhancement Improvements that refine user interactions, accessibility, or overall usability
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alperozturk96 @tobiasKaminsky @ZetaTom