BugFix - External Share Icon Appreance After Delete

[alperozturk96]

• Tests written, or not not needed

Steps to Reproduce:

1. Launch the app and log in.
2. Tap the share icon on any file or folder.
3. Enter an external email address and create share. Return to the file list and observe the share icon.
4. Delete the external share from the share detail screen and observe the share icon again.

Actual Result:

The share icon sometimes continues to display the "shared" state, or doesn't update at all even after a hard refresh.

Expected Result:

After deleting the share, the icon should return to its default (unshared) state consistently.

[alperozturk96]

/backport to stable-3.32

[tobiasKaminsky]

Not tried it, but what if you have like this

• file with two sharees, e.g. share via mail and to user1
• unshare one of them
  --> then this is triggered and set to false?
  Then it will not show the sharees?

android/app/src/main/java/com/owncloud/android/ui/adapter/OCFileListAdapter.java

Line 590 in 11bc0da

if ((file.isSharedWithMe() || file.isSharedWithSharee()) && !isMultiSelect() && !gridView &&

[alperozturk96]

Thank you for the feedback.

Since we are using ShareeListAdapter for both internal and external shares, and the fields sharedWithSharee and sharedViaLink are used as boolean indicators rather than actual share counts (where 1 represents that a share exists and 0 means no shares), we can simplify the logic.

After removing a share, we can check whether the corresponding adapter (sharesListInternal or sharesListExternal) is empty. If so, we can safely set sharedWithSharee or sharedViaLink to 0 to indicate that there are no remaining shares of that type.

pr is updated

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/15153.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[github-actions]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/15153-Screenshot-blue-Light-14-48

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	48	48
Errors	11	11

SpotBugs

Category	Base	New
Bad practice	62	62
Correctness	61	61
Dodgy code	299	299
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	2	2
Multithreaded correctness	35	35
Performance	48	48
Security	18	18
Total	533	533