Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add PHP 8.4 #6434

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore: add PHP 8.4 #6434

merged 1 commit into from
Nov 4, 2024

Conversation

miaulalala
Copy link
Contributor

Let's see if things go 💥

@miaulalala miaulalala added 2. developing Work in progress github_actions Pull requests that update GitHub Actions code labels Oct 17, 2024
@miaulalala miaulalala added this to the v5.1.0 milestone Oct 17, 2024
@miaulalala miaulalala self-assigned this Oct 17, 2024
Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.47%. Comparing base (a9b6627) to head (8cb3aed).
Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main    #6434   +/-   ##
=========================================
  Coverage     23.47%   23.47%           
  Complexity      454      454           
=========================================
  Files           247      247           
  Lines         11708    11708           
  Branches       2223     2212   -11     
=========================================
  Hits           2749     2749           
  Misses         8639     8639           
  Partials        320      320           
Flag Coverage Δ
javascript 15.05% <ø> (ø)
php 59.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@miaulalala miaulalala marked this pull request as ready for review October 17, 2024 13:46
Signed-off-by: Anna Larch <[email protected]>
@miaulalala miaulalala added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Nov 4, 2024
Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Green CI 👍

@miaulalala miaulalala merged commit e426cd4 into main Nov 4, 2024
37 checks passed
@miaulalala miaulalala deleted the chore/add-php-8.4 branch November 4, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews github_actions Pull requests that update GitHub Actions code
Projects
Status: ☑️ Done
Development

Successfully merging this pull request may close these issues.

2 participants