Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(calendarPicker): undefined calendar #6468

Merged
merged 1 commit into from
Nov 6, 2024
Merged

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Nov 6, 2024

fix #6461

Copy link

codecov bot commented Nov 6, 2024

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 23.47%. Comparing base (8cb3aed) to head (94fc5d1).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/components/AppointmentConfigModal.vue 0.00% 2 Missing ⚠️
src/components/Shared/CalendarPicker.vue 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6468      +/-   ##
============================================
- Coverage     23.47%   23.47%   -0.01%     
  Complexity      454      454              
============================================
  Files           247      247              
  Lines         11708    11710       +2     
  Branches       2212     2223      +11     
============================================
  Hits           2749     2749              
- Misses         8639     8641       +2     
  Partials        320      320              
Flag Coverage Δ
javascript 15.05% <0.00%> (-0.01%) ⬇️
php 59.42% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@st3iny st3iny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works. Can't be backported though, due to translation changes.

Please (manually) backport the bug fix part.

@st3iny st3iny added the 4. to release Ready to be released and/or waiting for tests to finish label Nov 6, 2024
@st3iny st3iny added this to the v5.1.0 milestone Nov 6, 2024
@st3iny st3iny merged commit 304050a into main Nov 6, 2024
35 of 37 checks passed
@st3iny st3iny deleted the Fix/6461/undefined-calendar branch November 6, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews 4. to release Ready to be released and/or waiting for tests to finish bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Appointment schedule Calendar Picker not showing after deleting calendar
2 participants