Add $shallow arg to ShareByCircleProvider::getSharesInFolder

[artonge]

A new $shallow argument was introduced to IShareProvider::getSharesInFolder in NC25 by nextcloud/server#31728.

This PR adds this new argument and the necessary changes to make it work based on this example https://github.com/nextcloud/server/pull/31728/files#diff-dee1351696d7eae959761edf66c8e5a9052e28be73319733d857a9ab2d9fc967=

Looks like in the context of ShareWrapperRequest, the $shallow argument can't be used as we only have the nodeId so we cannot use the same method as in other places:

if ($shallow) {
	$qb->andWhere($qb->expr()->eq('f.parent', $qb->createNamedParameter($node->getId())));
} else {
	$qb->andWhere($qb->expr()->like('f.path', $qb->createNamedParameter($this->dbConnection->escapeLikeParameter($node->getInternalPath()) . '/%')));
}

Should we change the methods to forward $node instead of $nodeId?

[ArtificialOwl]

Yes, it seems you can pass Folder (Node ?) instead of int in

circles/lib/ShareByCircleProvider.php

Line 411 in 94b67c2

(!is_null($node)) ? $node->getId() : 0,

without affecting the rest of the app

Not sure if $node can still really be null at this point of the process

[ArtificialOwl]

also, for the sql requestion (around

circles/lib/Db/ShareWrapperRequest.php

Line 382 in 94b67c2

}

) you can test:

$qb->like('path', $node->getInternalPath() . '/%', $aliasFileCache);

[ArtificialOwl]

no tested, looks good !