Skip to content

fix: add cache to joinedCircles API request #1840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

tcitworld
Copy link
Member

This deprecated API is only used by DAV, but doesn't benefit from the cache, which makes it VERY heavy when you have a lot of users using calendar intensively

This deprecated API is only used by DAV, but doesn't benefit from the cache, which makes it VERY
heavy when you have a lot of users using calendar intensively

Signed-off-by: Thomas Citharel <[email protected]>
Copy link

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To me this looks sensible. @ArtificialOwl what do you think?

@ArtificialOwl
Copy link
Member

Hello,

this has been fixed using probeCircles instead of getCircles which is more efficient.
Caching will also be implemented to probeCircles.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants