Skip to content

feat(psalm): Add all stubs #1875

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 4, 2025
Merged

feat(psalm): Add all stubs #1875

merged 8 commits into from
Mar 4, 2025

Conversation

provokateurin
Copy link
Member

I tried to fix a bunch of the errors that were uncovered by adding the proper stubs, but didn't manage to fix all of them since I don't understand everything yet.
I also don't understand why psalm doesn't properly understand that CoreQueryBuilder implements IQueryBuilder, but the change makes it work 🤷‍♀️

@come-nc
Copy link
Contributor

come-nc commented Feb 18, 2025

Why does it need such a recent PHP?

composer run psalm

> psalm.phar --threads=1 --no-cache

Box Requirements Checker
========================

> Using PHP 8.3.6
> PHP is using the following php.ini file:
  /etc/php/8.3/cli/php.ini

> Checking Box requirements:
  E..................

                                                                                                                                                                                                                   
 [ERROR] Your system is not ready to run the application.                                                                                                                                                          
                                                                                                                                                                                                                   

Fix the following mandatory requirements:
=========================================

 * The application requires the version "~8.1.31 || ~8.2.27 || ~8.3.16 || ~8.4.3" or greater.

Script psalm.phar --threads=1 --no-cache handling the psalm event returned with error code 1

@provokateurin
Copy link
Member Author

provokateurin commented Feb 18, 2025

Why does it need such a recent PHP?

Yeah it's a bit weird that the version requirements are so strict (maybe for security reasons, but that's not really psalms task?)

Copy link
Contributor

@come-nc come-nc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would prefer if the PHP version thing is solved and I can run the analysis locally.
Also the CI will have trouble I expect as it does not always have the last PHP?
And would be better if the IQueryBuilder thing is properly fixed as well.

Not gonna block this PR though, it’s still a step forward.

@provokateurin
Copy link
Member Author

I'll try to improve this PR, but I already gave up on the IQueryBuilder thing because there is no trace of what is wrong 🤷‍♀️

@provokateurin provokateurin enabled auto-merge March 4, 2025 07:21
@provokateurin provokateurin merged commit 31fd176 into master Mar 4, 2025
31 checks passed
@provokateurin provokateurin deleted the feat/psalm/stubs branch March 4, 2025 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants