Merged
Conversation
313d9be to
7f2facc
Compare
ArtificialOwl
approved these changes
Feb 18, 2025
come-nc
reviewed
Feb 18, 2025
Contributor
|
Why does it need such a recent PHP?
|
Member
Author
Yeah it's a bit weird that the version requirements are so strict (maybe for security reasons, but that's not really psalms task?) |
come-nc
approved these changes
Feb 18, 2025
Contributor
come-nc
left a comment
There was a problem hiding this comment.
I would prefer if the PHP version thing is solved and I can run the analysis locally.
Also the CI will have trouble I expect as it does not always have the last PHP?
And would be better if the IQueryBuilder thing is properly fixed as well.
Not gonna block this PR though, it’s still a step forward.
Member
Author
|
I'll try to improve this PR, but I already gave up on the IQueryBuilder thing because there is no trace of what is wrong 🤷♀️ |
7f2facc to
0fce851
Compare
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
0fce851 to
dc1dc88
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I tried to fix a bunch of the errors that were uncovered by adding the proper stubs, but didn't manage to fix all of them since I don't understand everything yet.
I also don't understand why psalm doesn't properly understand that CoreQueryBuilder implements IQueryBuilder, but the change makes it work 🤷♀️