feature: send email to internal users of circles when shared with circle#2050
Conversation
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Isn't this kind of logic supposed to be implemented through IShareProviderWithNotification?
Signed-off-by: yemkareems <yemkareems@gmail.com>
Refactored service to provider |
…WithNotification and set share sendmail to true for circle share in both share and wrapper objects. Send public share link in email. Rename provider to helper Signed-off-by: yemkareems <yemkareems@gmail.com>
…efactor tests Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
provokateurin
left a comment
provokateurin
left a comment
There was a problem hiding this comment.
Woops I forgot to submit my review
Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
…dition checked once, sendShareNotification type hinting done, sendUserShareMail passing only the share and arguments type hinted, tests refactored Signed-off-by: yemkareems <yemkareems@gmail.com>
…b.com:nextcloud/circles into feature/notify-internal-users-on-circle-share
Signed-off-by: yemkareems <yemkareems@gmail.com>
… query user if not required, sendUserShareMail adjusted, dont send email to initiator email condition added and test refactored accordingly Signed-off-by: yemkareems <yemkareems@gmail.com>
…ding methods to send mail service Signed-off-by: yemkareems <yemkareems@gmail.com>
Signed-off-by: yemkareems <yemkareems@gmail.com>
…ed, iShare got from wrappedShare object for sendUserShareMail Signed-off-by: yemkareems <yemkareems@gmail.com>
|
better approach, thanks for the changes |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
feature: send email to internal users of circles when shared with circle