Skip to content

Commit

Permalink
test(cypress): Start built-in PHP webservers with three workers
Browse files Browse the repository at this point in the history
This fixes testing things that involve API calls to async events in
circles, e.g. removing a member from a circle.

Signed-off-by: Jonas <[email protected]>
  • Loading branch information
mejo- committed Sep 25, 2023
1 parent 8c30001 commit 3742ef2
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/cypress.yml
Original file line number Diff line number Diff line change
Expand Up @@ -192,6 +192,8 @@ jobs:
- name: Run Nextcloud
run: php -S 0.0.0.0:8081 &
env:
PHP_CLI_SERVER_WORKERS: 3

- name: Cypress run
uses: cypress-io/github-action@v6
Expand Down
4 changes: 1 addition & 3 deletions cypress/e2e/collective-members.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -101,9 +101,7 @@ describe('Collective members', function() {
cy.wait('@removeCircleMember')
cy.wait('@getCircleMembers')

// Fixme: removing members from a circle is async and doesn't work with
// the single process PHP webserver used in CI.
// cy.get('.current-members .member-row').should('not.contain', member)
cy.get('.current-members .member-row').should('not.contain', member)
})
})
})

0 comments on commit 3742ef2

Please sign in to comment.