Skip to content

[stable7.0] fix: Instantiation of ContactsManager #4399

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 19, 2025

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Mar 19, 2025

Backport of PR #4394

@backportbot backportbot bot requested a review from hamza221 March 19, 2025 10:29
@backportbot backportbot bot requested a review from artonge March 19, 2025 10:29
@backportbot backportbot bot added bug Something isn't working 3. to review Waiting for reviews php Pull requests that update Php code labels Mar 19, 2025
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.54%. Comparing base (3a4b7d2) to head (cbf9d6b).
Report is 2 commits behind head on stable7.0.

Files with missing lines Patch % Lines
lib/Service/SocialApiService.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##             stable7.0    #4399       +/-   ##
================================================
+ Coverage         2.32%   65.54%   +63.21%     
- Complexity           0      265      +265     
================================================
  Files               96       26       -70     
  Lines             4765      772     -3993     
  Branches          1187        0     -1187     
================================================
+ Hits               111      506      +395     
+ Misses            4533      266     -4267     
+ Partials           121        0      -121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@artonge artonge merged commit 039c3ec into stable7.0 Mar 19, 2025
35 of 36 checks passed
@artonge artonge deleted the backport/4394/stable7.0 branch March 19, 2025 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug Something isn't working php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant