-
Notifications
You must be signed in to change notification settings - Fork 184
refactor: use server container for contacts manager #4412
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cef9b8
to
02ed560
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4412 +/- ##
============================================
+ Coverage 2.32% 65.62% +63.30%
- Complexity 0 265 +265
============================================
Files 96 26 -70
Lines 4767 771 -3996
Branches 1188 0 -1188
============================================
+ Hits 111 506 +395
+ Misses 4535 265 -4270
+ Partials 121 0 -121 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ChristophWurst
approved these changes
Apr 4, 2025
ChristophWurst
requested changes
Apr 4, 2025
ChristophWurst
approved these changes
Apr 4, 2025
Signed-off-by: Hamza Mahjoubi <[email protected]>
2a650ee
to
7a028d1
Compare
/backport to stable7.0 |
/backport to stable6.0 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app uses internals of another app. With #4394 we had to adjust the constructor arguments because they changed.
This PR replaces the direct instantiation with a service locator.