Skip to content

refactor: use server container for contacts manager #4412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2025

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Apr 4, 2025

The app uses internals of another app. With #4394 we had to adjust the constructor arguments because they changed.
This PR replaces the direct instantiation with a service locator.

@hamza221 hamza221 added the 3. to review Waiting for reviews label Apr 4, 2025
@hamza221 hamza221 requested a review from ChristophWurst April 4, 2025 11:05
@hamza221 hamza221 self-assigned this Apr 4, 2025
@hamza221 hamza221 force-pushed the refctor/socialApi branch from 0cef9b8 to 02ed560 Compare April 4, 2025 11:06
Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.62%. Comparing base (84b18b4) to head (7a028d1).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lib/Service/SocialApiService.php 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##              main    #4412       +/-   ##
============================================
+ Coverage     2.32%   65.62%   +63.30%     
- Complexity       0      265      +265     
============================================
  Files           96       26       -70     
  Lines         4767      771     -3996     
  Branches      1188        0     -1188     
============================================
+ Hits           111      506      +395     
+ Misses        4535      265     -4270     
+ Partials       121        0      -121     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hamza221 hamza221 requested a review from ChristophWurst April 4, 2025 12:17
@hamza221 hamza221 force-pushed the refctor/socialApi branch from 2a650ee to 7a028d1 Compare April 4, 2025 13:06
@hamza221 hamza221 enabled auto-merge April 4, 2025 13:07
@hamza221
Copy link
Contributor Author

hamza221 commented Apr 4, 2025

/backport to stable7.0

@hamza221 hamza221 merged commit 7dba068 into main Apr 4, 2025
38 checks passed
@hamza221 hamza221 deleted the refctor/socialApi branch April 4, 2025 13:08
@hamza221
Copy link
Contributor Author

hamza221 commented Apr 4, 2025

/backport to stable6.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants