-
Notifications
You must be signed in to change notification settings - Fork 279
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: export doesn't handle lists with no cards #5096
Conversation
I've fixed the |
Fine for me without tests for now as we don't have the CSV feature covered at all yet, I might push them separately |
Signed-off-by: Michał Walczak <[email protected]>
/backport to stable27 |
/backport to stable26 |
/backport to stable25 |
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
Thanks a lot for the fix :) |
Ah only there on 26 so we can skip the stable26 backport |
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! |
Summary
If statement prevents the script from crashing in case there's a stack without any cards.
I would love if someone took a look at it, I'm not a programmer by trade.
I don't know if this requires tests, or even how to write them at this point.
One thing this still doesn't handle is exporting information about the empty stack even existing.
On import it cannot be recreated.
Probably something for a different PR though.
If needed, I'll update.
TODO
Checklist