Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: export doesn't handle lists with no cards #5096

Merged
merged 1 commit into from
Sep 13, 2023
Merged

fix: export doesn't handle lists with no cards #5096

merged 1 commit into from
Sep 13, 2023

Conversation

magikmw
Copy link
Contributor

@magikmw magikmw commented Sep 8, 2023

Summary

If statement prevents the script from crashing in case there's a stack without any cards.
I would love if someone took a look at it, I'm not a programmer by trade.
I don't know if this requires tests, or even how to write them at this point.

One thing this still doesn't handle is exporting information about the empty stack even existing.
On import it cannot be recreated.
Probably something for a different PR though.

If needed, I'll update.

TODO

  • ...

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@magikmw
Copy link
Contributor Author

magikmw commented Sep 10, 2023

I've fixed the if( linter's issue, but I have no idea what's that other problem about.
Also rebase to current main.

@juliusknorr
Copy link
Member

Fine for me without tests for now as we don't have the CSV feature covered at all yet, I might push them separately

@juliusknorr juliusknorr merged commit 57d6436 into nextcloud:main Sep 13, 2023
12 checks passed
@juliusknorr
Copy link
Member

/backport to stable27

@juliusknorr
Copy link
Member

/backport to stable26

@juliusknorr
Copy link
Member

/backport to stable25

@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable25
git pull origin stable25

# Create the new backport branch
git checkout -b fix/foo-stable25

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@juliusknorr
Copy link
Member

Thanks a lot for the fix :)

@juliusknorr
Copy link
Member

Ah only there on 26 so we can skip the stable26 backport

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[1.9.2] Export doesn't handle lists with no cards
2 participants