Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix adding account and skipping folder configuration crash. #7436

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Fix adding account and skipping folder configuration crash. #7436

wants to merge 14 commits into from
+141 −143

Conversation

camilasan
Copy link
Member

@camilasan camilasan commented Oct 30, 2024 •
edited
Loading

  • when adding account on mac OS and skipping the folder configuration step, it would crash and it would add an empty user as an account.
  • the dialog for configuring folder it was never going away once the user would click on skip.

@camilasan camilasan force-pushed the bugfix/accounts2 branch 2 times, most recently from 24235b5 to afc2afc Compare November 4, 2024 20:13
@camilasan camilasan changed the title WIP: Bugfix/accounts2 Fix adding account and skipping folder configuration crash. Nov 5, 2024
@camilasan camilasan marked this pull request as ready for review November 5, 2024 09:41
@camilasan
Copy link
Member Author

/backport to stable-3.14

@camilasan camilasan added this to the 3.14.5 milestone Nov 5, 2024
@Rello Rello modified the milestones: 3.14.5, 3.15.0 Nov 11, 2024
@camilasan
Use slotComputeOverallSyncStatus as a slot.
3a4b1f2 
- Use qAsConst.

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Fix warning "Calling C++ methods with 'this' objects different from t…
0036c91 
…he one they were retrieved from is broken"

https://doc.qt.io/qt-6/qtqml-documents-structure.html#nativemethodbehavior

Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Modernize Account::displayName().
002371b 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Use slots as slots.
17fdc45 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Diferentiate between display name and dav display name.
5a67e8b 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Rename vars: _am => _networkAccessManager, a => newAccountData.
1109161 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Use saveAccount for adding single account.
e9a9251 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Add {} to single line if.
976325a 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
acc => account.
8f3fe6d 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
wiz => owncloudSetupWizard.
ef0ab50 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Call for done() when skipping folder configuration.
0bad474 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Remove check before setting display name.
30b4767 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Fix tests: make sure displayName is not empty.
9f7920b 
Signed-off-by: Camila Ayres <[email protected]>
@camilasan
Correct Q_PROPERTY for _davDisplayName.
7d44d1e 
Signed-off-by: Camila Ayres <[email protected]>
@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-7436-7d44d1e529c43b07e0c1db657b60ffc7fd0ce078-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 14, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
15.1% Coverage on New Code (required ≥ 80%)
53 New Code Smells (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)
D Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claucambra claucambra Awaiting requested review from claucambra

@mgallien mgallien Awaiting requested review from mgallien

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
backport-request
Projects
None yet
Milestone
3.15.0
Development

Successfully merging this pull request may close these issues.
3 participants
@camilasan @nextcloud-desktop-bot @Rello