Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation for change color for tags and delete tags #11322

Merged
merged 1 commit into from
Nov 30, 2023
Merged

Add documentation for change color for tags and delete tags #11322

merged 1 commit into from
Nov 30, 2023

Conversation

GretaD
Copy link
Contributor

@GretaD GretaD commented Nov 27, 2023

@GretaD GretaD self-assigned this Nov 27, 2023
@GretaD
Copy link
Contributor Author

GretaD commented Nov 27, 2023

Since i was writing about tags anyway, i documented also the delete tags, i hope thats ok @hamza221 :)

@GretaD GretaD force-pushed the add/color-delete-tags branch from 498e54b to beced28 Compare November 27, 2023 20:22
joshtrichards
joshtrichards approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@joshtrichards joshtrichards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the use of the versionadded directives! We should work to get better at using those (and similar directives) through all the manuals. It's only been used in the Admin Manual once. 😄

@ChristophWurst
Copy link
Member

needs backports

@ChristophWurst ChristophWurst merged commit 376b098 into master Nov 30, 2023
8 checks passed
@ChristophWurst ChristophWurst deleted the add/color-delete-tags branch November 30, 2023 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshtrichards joshtrichards joshtrichards approved these changes

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@hamza221 hamza221 Awaiting requested review from hamza221

Assignees

@GretaD GretaD

Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@GretaD @ChristophWurst @joshtrichards