Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable30] fix: cards should have the same size #1400

Merged
merged 2 commits into from
Oct 8, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented Oct 7, 2024

Backport of #1399

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

Signed-off-by: Simon L. <[email protected]>

[skip ci]
@szaimen
Copy link
Collaborator

szaimen commented Oct 7, 2024

/compile

@szaimen szaimen marked this pull request as ready for review October 7, 2024 22:45
Signed-off-by: nextcloud-command <[email protected]>
@szaimen szaimen merged commit b816ce7 into stable30 Oct 8, 2024
38 of 40 checks passed
@szaimen szaimen deleted the backport/1399/stable30 branch October 8, 2024 08:26
This was referenced Oct 10, 2024
@blizzz
Copy link
Member

blizzz commented Oct 10, 2024

@szaimen why did you merge it despite red CI?

@szaimen
Copy link
Collaborator

szaimen commented Oct 10, 2024

Because there is another rc or is this only for specific changes?

@blizzz
Copy link
Member

blizzz commented Oct 10, 2024

Because there is another rc or is this only for specific changes?

Yes. This was an unplanned delay. This check is not a decoration. Please check with the release team in such cases, when you think the PR is sufficiently important.

@szaimen
Copy link
Collaborator

szaimen commented Oct 10, 2024

All right. Will check with the team next time first. Sorry for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants