-
Notifications
You must be signed in to change notification settings - Fork 105
feat: add form locking mechanism and share edit
permission
#2737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Chartman123
wants to merge
5
commits into
main
Choose a base branch
from
feat/shareEditPermission
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f9b7c67
to
fc37acb
Compare
fc37acb
to
a3198a4
Compare
18c3220
to
5c16474
Compare
Open
77df1d9
to
59282d7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2737 +/- ##
============================================
- Coverage 45.58% 44.21% -1.38%
- Complexity 984 1019 +35
============================================
Files 79 80 +1
Lines 3565 3662 +97
============================================
- Hits 1625 1619 -6
- Misses 1940 2043 +103 🚀 New features to boost your workflow:
|
986e8f9
to
a342623
Compare
edit
permission
db61925
to
5b0d4a6
Compare
a00eca1
to
aaff8fa
Compare
aaff8fa
to
ff55376
Compare
- Implemented form locking functionality to prevent concurrent edits. - Updated API responses to include `lockedBy` and `lockedUntil` fields. - Enhanced permission checks to ensure only the form owner can transfer ownership. - Revised documentation to reflect changes in form data structure and API behavior. Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
Signed-off-by: Christian Hartmann <[email protected]>
…for archiving, locking, and ownership transfer Signed-off-by: Christian Hartmann <[email protected]>
ff55376
to
0194dbf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
2. developing
Work in progress
enhancement
New feature or request
feature: 📑 form creation
feature: 👥 sharing settings
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lockedBy
andlockedUntil
togetForm
andgetForms
edit
permission to shares in frontend (backend already handles it correctly)What should someone with edit permissions be able to do?
closed
archived
permitAllUsers
,showToAllUsers
)