feat(MountProvider): Implement IPartialMountProvider #4262
+85
−22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
provokateurin
added
enhancement
2. developing
icewind1991
reviewed
Jan 14, 2026
icewind1991
reviewed
Jan 14, 2026
Signed-off-by: provokateurin <[email protected]>
provokateurin
force-pushed
the
feat/partial-mount-provider
branch
from
838475e to
70bebe9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was not able to really test it, because the codepath is never triggered (without any modifications in SetupManager), but from step debugging the output looked good to me.
From nextcloud/server#57497 I gathered that I don't even need to iterate the
$mountProviderArgs, so maybe that loop could be removed.Also this method doesn't implement the conflict resolution, which might be necessary to add.