fix: Optimize group folder queries #4283
Open
+115
−15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rello
changed the title
provokateurin
requested changes
Jan 22, 2026
| $applicableMap[$id] = []; | ||
| } | ||
|
|
||
| if (!$row['circle_id']) { |
Member
There was a problem hiding this comment.
This check is very ugly, at least invert it
Comment on lines
+573
to
+580
| $query->select('folder_id') | ||
| ->from('group_folders') | ||
| ->where($query->expr()->eq('mount_point', $query->createNamedParameter($mountPoint))) | ||
| ->setMaxResults(1); | ||
|
|
||
| $result = $query->executeQuery(); | ||
| $exists = $result->fetchOne() !== false; | ||
| $result->closeCursor(); |
Member
There was a problem hiding this comment.
Selecting the count of rows might allow the DB to operate more efficiently.
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Rello <Rello@users.noreply.github.com>
Co-authored-by: Kate <26026535+provokateurin@users.noreply.github.com> Signed-off-by: Rello <Rello@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Description
lib/Controller/FolderController.phpwith a call toFolderManager::mountPointExists()to perform a single targeted query.mountPointExists()tolib/Folder/FolderManager.phpto check for a mount point using a single-row query.getApplicableForFolders()andgetApplicableForFolder()andgetFolderMappingsForFolders()inlib/Folder/FolderManager.phpto fetch applicable groups/circles and manage mappings for a specified list of folder IDs.getAllFoldersWithSize(),getAllFoldersForUserWithSize(),getFolder(),getGroups(), andgetCircles()to use the new scoped helpers instead of loading all applicable/mapping rows, including safe early-return when the folder ID list is empty.Background