Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable pdf preview gnerator through Collabora if server already has support for it #3112

Merged
merged 1 commit into from
Aug 16, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Aug 16, 2023

If the core preview provider for PDF is enabled we don't need to register the one from Collabora which involves additional network transfer and is likely slower due to that.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@cypress
Copy link

cypress bot commented Aug 16, 2023

Passing run #516 ↗︎

0 25 0 0 Flakiness 0

Details:

fix: Disable pdf preview gnerator through Collabora if server already has suppor...
Project: Richdocuments Commit: d2374f7555
Status: Passed Duration: 02:50 💡
Started: Aug 16, 2023 8:31 AM Ended: Aug 16, 2023 8:34 AM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@juliusknorr juliusknorr marked this pull request as ready for review August 16, 2023 08:41
@juliusknorr juliusknorr merged commit 2d90497 into main Aug 16, 2023
42 checks passed
@juliusknorr juliusknorr deleted the bugfix/noid/pdf-disable branch August 16, 2023 17:55
@juliusknorr
Copy link
Member Author

/backport to stable27

@juliusknorr
Copy link
Member Author

/backport to stable26

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@backportbot-nextcloud
Copy link

The backport to stable26 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable26
git pull origin stable26

# Create the new backport branch
git checkout -b fix/foo-stable26

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable26

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen
Copy link
Contributor

szaimen commented Aug 29, 2023

/backport to stable27

@backportbot-nextcloud
Copy link

The backport to stable27 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable27
git pull origin stable27

# Create the new backport branch
git checkout -b fix/foo-stable27

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123

# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable27

More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport

@szaimen szaimen restored the bugfix/noid/pdf-disable branch August 29, 2023 17:04
@szaimen szaimen deleted the bugfix/noid/pdf-disable branch August 29, 2023 17:07
@szaimen
Copy link
Contributor

szaimen commented Aug 29, 2023

#3146

@juliusknorr
Copy link
Member Author

stable26 in #3176

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants