Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skip css variable if not set (prevent warning on COOL side) #4178

Merged
merged 2 commits into from
Nov 13, 2024
Merged

skip css variable if not set (prevent warning on COOL side) #4178

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
179cdb1
skip css variable if not set (prevent warning on COOL side)
timar Oct 26, 2024
2688b25
Merge branch 'main' into private/timar/cssvars
timar Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/helpers/coolParameters.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,8 +128,8 @@ const generateCSSVarTokens = () => {
const lightStyle = window.getComputedStyle(lightElement).getPropertyValue(varName)
const darkStyle = window.getComputedStyle(darkElement).getPropertyValue(varName)

str += varName.replace('--', '--nc-light-') + '=' + lightStyle.trim() + ';'
str += varName.replace('--', '--nc-dark-') + '=' + darkStyle.trim() + ';'
if (lightStyle) str += varName.replace('--', '--nc-light-') + '=' + lightStyle.trim() + ';'
if (darkStyle) str += varName.replace('--', '--nc-dark-') + '=' + darkStyle.trim() + ';'

// Workaround for now as we need primary-invert-if-dark which is not available on server yet
if (varName === '--primary-invert-if-bright') {
Expand Down
Loading