Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(share): link share of federated share #4195

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(share): link share of federated share #4195

wants to merge 1 commit into from

Conversation

max-nextcloud
Copy link
Contributor

  • Target version: main

Summary

Fix opening link shares to federated shares.

I know that's complicated so let me explain:

  • [email protected] shares a file with [email protected] via federated sharing.
  • Bob creates a public link share to that file.
  • When a guest visits that share it should open nicely.

TODO

  • Add cypress test.

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation is not needed.

juliusknorr
juliusknorr approved these changes Nov 5, 2024
View reviewed changes
Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Adding tests would be awesome. The other cypress failures in here are unrelated

@juliusknorr juliusknorr added bug Something isn't working 2. developing Work in progress feature: federation regression labels Nov 5, 2024
@juliusknorr juliusknorr force-pushed the fix/fedarated-public-link-share branch from df6cd22 to bd19220 Compare November 5, 2024 07:42
@juliusknorr
Copy link
Member

Rebased as main should be passing again 🥳

@max-nextcloud max-nextcloud self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

@elzody elzody Awaiting requested review from elzody

Assignees

@max-nextcloud max-nextcloud

Labels
2. developing Work in progress bug Something isn't working feature: federation regression
Projects
📝 Office team
Status: 🏗️ In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-nextcloud @juliusknorr