fix: Ensure public links are always considered public#5207
Open
juliusknorr wants to merge 1 commit intomainfrom
Open
fix: Ensure public links are always considered public#5207juliusknorr wants to merge 1 commit intomainfrom
juliusknorr wants to merge 1 commit intomainfrom
Conversation
Signed-off-by: Julius Knorr <[email protected]>
juliusknorr
force-pushed
the
fix/5198
branch
from
61bc27b to
90b8fcd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #5198
A public share link can also be opened with an active user session. In this case the share button was shown but not working. With this change we let the isPublic variable be what it is supposed to, a check if the file is accessed through a public share link.