Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FilePath as a rule criteria #23452

Closed
wants to merge 1 commit into from
Closed

Add FilePath as a rule criteria #23452

wants to merge 1 commit into from

Conversation

martin-rueegg
Copy link
Contributor

@martin-rueegg martin-rueegg commented Oct 14, 2020

May Fix #19810

Signed-off-by: Martin Rüegg [email protected]

This patch allows to create a rule based on the file path.

See #22976 for more details. I hope to get more attention by the devs by creating a PR.

Signed-off-by: Martin Rüegg <[email protected]>
@skjnldsv
Copy link
Member

see #23451

@juliusknorr
Copy link
Member

The main issue i have with the file path based rules is that this will not work properly with shares and might break as soon as the user renames a file or folder in the in the path. cc @blizzz @jancborchardt Since we discussed this during the flow hackweek iirc.

@blizzz
Copy link
Member

blizzz commented Nov 2, 2020

The main issue i have with the file path based rules is that this will not work properly with shares and might break as soon as the user renames a file or folder in the in the path. cc @blizzz @jancborchardt Since we discussed this during the flow hackweek iirc.

Exactly. And especially since share recipients can move the files and folders around, not effecting the owner's directory structure. That's why using tags is recommended. This even works with subfolders, e.g.

  • 📁 tagged "Foobar"
    • 📁 (not tagged)
      • 📁 file "Barfoo" thrown into

The file upload of Barfoo then will apply to rules that have "Systemtag is Foobar" as constraint.

@martin-rueegg
Copy link
Contributor Author

Sorry guys for my late reply - I was on sick leave.

Yes, I have managed to get the thing working by adding a tag to the containing folder and then adjust the flow to use that tag instead.

Unfortunately, I have not been able to find any documentation about this. There may be more information available at the https://portal.nextcloud.com, which is behind a paywall. Seems that this is now the new strategy of Nextcloud GmbH: open source but closed doc. That will make it harder to contribute in the future. A very sad development for the community ...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flow check for containing directory
4 participants