Skip to content

fix: use non-mocked app manager for router test #46416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

kesselb
Copy link
Contributor

@kesselb kesselb commented Jul 10, 2024

  • Resolves: noid

Summary

The mocked version of IAppManager will return null for getAppPath and thus parts of the tests are not executed.

To avoid more mocking a "partly" mocked IAppManager instanced is used.

TODO

  • CI
  • Review

Checklist

The mocked version of IAppManager will return null for getAppPath and thus parts of the tests are not executed.

To avoid more mocking a "partly" mocked IAppManager instanced is used.

Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
@kesselb kesselb force-pushed the bug/noid/more-routing-weirdness branch from 44d8d0f to b8a0401 Compare July 10, 2024 22:27
@skjnldsv skjnldsv marked this pull request as draft November 15, 2024 13:07
@skjnldsv skjnldsv added this to the Nextcloud 32 milestone Jan 30, 2025
@kesselb
Copy link
Contributor Author

kesselb commented Jun 10, 2025

Replaced by #47927

@kesselb kesselb closed this Jun 10, 2025
@kesselb kesselb deleted the bug/noid/more-routing-weirdness branch June 10, 2025 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2. developing Work in progress bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants