fix(files): Reset drop notice on firefox #47465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Firefox bugs that cause this:
And yes those are open since Firefox 4(!) |
|
/backport to stable30 |
|
/backport to stable29 |
skjnldsv
approved these changes
Aug 25, 2024
artonge
reviewed
Aug 26, 2024
susnux
force-pushed
the
fix/files-drop-notice
branch
from
7ef9bb6
to
f3a2d3b
Compare
susnux
force-pushed
the
fix/files-drop-notice
branch
from
f3a2d3b
to
98d5d86
Compare
|
/compile |
artonge
reviewed
Aug 26, 2024
susnux
commented
Aug 26, 2024
|
BTW not sure if this has side effects, but to prevent them if they exist I do not like |
susnux
force-pushed
the
fix/files-drop-notice
branch
from
506deec
to
a86ce67
Compare
|
/compile amend/ |
nextcloud-command
force-pushed
the
fix/files-drop-notice
branch
from
a86ce67
to
b1017b4
Compare
artonge
approved these changes
Aug 26, 2024
On firefox there is an old bug where when you move a dragged file outside the window the `dragleave` event is never emitted. So we just use a timeout to reset the drag over state. Also a small change: Use the ID of the main container instead of relying on tag name and class. (The ID is guranteed as other APIs rely on it, while the class is just used internally). Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
fix/files-drop-notice
branch
from
b1017b4
to
744b41b
Compare
This was referenced Aug 26, 2024
8 tasks
|
/backport to stable28 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On Firefox there is an old bug where when you move a dragged file outside the window the
dragleaveevent is never emitted. So we just use a timeout to reset the drag over state.Also a small change: Use the ID of the main container instead of relying on tag name and class. (The ID is guaranteed as other APIs rely on it, while the class is just used internally).
Screen recording
This is how the bug looks (before this PR):
Bildschirmaufnahme_20240824_120143.webm
Checklist