feat(trashbin): Allow emptying trash #49171
Open
+87
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <[email protected]>
Signed-off-by: Christopher Ng <[email protected]>
Pytal
added
enhancement
3. to review
skjnldsv
reviewed
Nov 9, 2024
| const dialog = getDialogBuilder(t('files_trashbin', 'Confirm permanent deletion')) | ||
| .setSeverity(DialogSeverity.Warning) | ||
| // TODO Add note for groupfolders | ||
| .setText(t('files_trashbin', "Are you sure you want to permanently delete the items in deleted files? You can't undo this action.")) |
There was a problem hiding this comment.
The phrasing looks odd to me :)
Maybe something like:
Permanently delete all files and folders in the trash? This cannot be undone.
There was a problem hiding this comment.
In the UI we call it "Deleted files" so this would be inconsistent, maybe we should change it to "Trash" or "Trash bin" everywhere @marcoambrosini?
marcoambrosini
approved these changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5534
Summary
Adds a button to empty the trashbin.
The TODO requries more adjustments so it will be done separately.
Checklist