refactor(files): Adjust useNavigation composable to enforce active view
#49301
+35
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
susnux
added
3. to review
skjnldsv
approved these changes
Nov 15, 2024
Pytal
approved these changes
Nov 15, 2024
susnux
force-pushed
the
refactor/files-required-navigation
branch
from
d61be26
to
c0f02c9
Compare
|
/compile |
…view In some cases it is guaranteed that we have a proper active view, e.g. when the file list is loaded (so within FileEntry* components). This does not change anything but the Typescript types, so the `currentView` is typed as `View` instead of `View | null´. Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
susnux
force-pushed
the
refactor/files-required-navigation
branch
from
575340b
to
ec1c4d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In some cases it is guaranteed that we have a proper active view, e.g. when the file list is loaded (so within
FileEntry*components). This does not change anything but the Typescript types, so thecurrentViewis typed asViewinstead of `View | null´.Checklist