Skip to content

SimpleFS: Add getFullDirectoryListing for complete directory listing #50145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

SimpleFS: Add getFullDirectoryListing for complete directory listing #50145

wants to merge 1 commit into from

Conversation

codewithvk
Copy link

@codewithvk codewithvk commented Jan 11, 2025 •
edited
Loading

  • Adds getFullDirectoryListing to list both files and folders.
  • Keeps getDirectoryListing for files only.
  • Resolves: #

Summary

TODO

  • ...

Checklist

@codewithvk codewithvk mentioned this pull request Jan 11, 2025
Merged
@codewithvk codewithvk force-pushed the private/codewithvk/simple_fs_fix branch 2 times, most recently from 6d47475 to 42be9e7 Compare January 12, 2025 07:02
@juliusknorr juliusknorr self-requested a review January 13, 2025 08:30
@juliusknorr juliusknorr added this to the Nextcloud 32 milestone Jan 13, 2025
juliusknorr
juliusknorr reviewed Jan 13, 2025
View reviewed changes
juliusknorr
juliusknorr reviewed Jan 13, 2025
View reviewed changes
@codewithvk codewithvk force-pushed the private/codewithvk/simple_fs_fix branch from 42be9e7 to f948518 Compare January 13, 2025 09:06
@codewithvk codewithvk marked this pull request as ready for review January 16, 2025 05:55
@codewithvk
SimpleFS: Add getFullDirectoryListing for complete directory listing
e10d597 
- Adds getFullDirectoryListing to list both files and folders.
- Keeps getDirectoryListing for files only.

Signed-off-by: codewithvk <[email protected]>
@codewithvk codewithvk force-pushed the private/codewithvk/simple_fs_fix branch from f948518 to e10d597 Compare January 23, 2025 07:15
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

@juliusknorr
Copy link
Member

We did use a different approach in richdocuments, so I guess we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr left review comments

Assignees
No one assigned
Labels
2. developing Work in progress enhancement feedback-requested
Projects
None yet
Milestone
Nextcloud 32
Development

Successfully merging this pull request may close these issues.
2 participants
@codewithvk @juliusknorr