fix: support longer index and table names #51593
Open
+721
−459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We do not support Oracle 11 anymore but at least Oracle 12c (12.2). So the limitation is gone (Oracle now supports up to 128 character long names). Instead we are now limited by MySQL (64 characters) and PostgreSQL (63 characters). Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
Signed-off-by: Ferdinand Thiessen <[email protected]>
susnux
added
2. developing
susnux
force-pushed
the
chore/support-longer-names
branch
4 times, most recently
from
1d770b0 to
98d731d
Compare
susnux
requested review from
artonge,
yemkareems,
provokateurin and
nickvergessen
and removed request for
a team
susnux
added
3. to review
nickvergessen
requested changes
Mar 24, 2025
Signed-off-by: Ferdinand Thiessen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If Oracle is not explicitly disabled by an app we check the table names / key names / column names for legacy Oracle length of max. 30 characters.
But since Oracle 12c the limit was increased to 128 characters.
So nowadays we are limited by MySQL / Mariadb and Postgres:
This PR adjusts the checks to only check for Oracle specific behavior but limit the name length to 63.
Checklist