fix: use correct date format for expires, last-modified, and if-modified-since headers #52743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
requested review from
skjnldsv,
yemkareems and
provokateurin
and removed request for
a team
kesselb
changed the title
|
I remember having come across this in the past, but didn't see a benefit in changing something if it currently works just fine. CC @Leptopoda |
|
Yeah, I get your point - nothing is really broken, and most clients or proxies probably just assume GMT anyway. But still, I think it’s worth changing. The current format isn’t even listed as a valid alternative in the RFC — it’s just plain wrong. And if there’s no real downside to fixing it, why not just make it correct and be spec-compliant? |
provokateurin
approved these changes
May 19, 2025
kesselb
force-pushed
the
bug/noid/expires-date-format
branch
from
5d567c7 to
226fbe7
Compare
skjnldsv
approved these changes
May 21, 2025
…ince headers Before: Sat, 10 May 2025 18:17:41 +0000 After: Sat, 10 May 2025 18:17:41 GMT RFC: https://httpwg.org/specs/rfc9110.html#http.date Signed-off-by: Daniel Kesselberg <[email protected]>
Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bug/noid/expires-date-format
branch
from
226fbe7 to
1ac85a3
Compare
skjnldsv
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Sat, 10 May 2025 18:17:41 +0000Sat, 10 May 2025 18:17:41 GMTRFC: https://httpwg.org/specs/rfc9110.html#http.date
Chrome and Firefox seem quite easy about the format of the headers. I couldn't see a difference in their behavior regarding caching the files, so I wouldn't backport it.
Checklist