-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix: unblock ffmpeg on some broken videos #53000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thanks for taking care @blizzz 👍 I recall some older PRs that aimed to achieve the same goal. They might be useful for you: |
This comment was marked as resolved.
This comment was marked as resolved.
Updated the video, fixed cs and reuse, should be good for a final rebase |
b4b9a30
to
9cd180e
Compare
Co-authored-by: Joas Schilling <[email protected]> Signed-off-by: Arthur Schiwon <[email protected]>
9cd180e
to
bdc6898
Compare
Thanks for linking them! The latter looks interesting (this part is also in the first one), would need more testing though. If this works properly, it appears more reliable than just preferring STDERR. |
/backport to stable31 |
/backport to stable30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and works 👍
I don't understand why, but it's nice 😆
/backport to stable29 |
The backport to # Switch to the target branch and update it
git checkout stable29
git pull origin stable29
# Create the new backport branch
git checkout -b backport/53000/stable29
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick bdc68989
# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/53000/stable29 Error: Failed to check for changes with origin/stable29: No changes found in backport branch Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports. |
Summary
On some (semi-)broken videos it might be, that we do not get information with SDTOUT and keep waiting for it. Because it is an external process, the PHP time limit is not in effect. Checking STDERR first solves this problem interestingly.
TODO
\Test\Preview\Provider::dimensionsDataProvider
.Checklist