Skip to content

fix(files_versions): "undefined restored" on restore #53147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

xlejo
Copy link
Contributor

@xlejo xlejo commented May 28, 2025

Summary

Solves the success message "undefined restored" when restore a file.

This issue was already solved in pull request #49664, but wasn't merged.

Checklist

@xlejo xlejo requested a review from a team as a code owner May 28, 2025 02:34
@xlejo xlejo requested review from nfebe, skjnldsv and sorbaugh and removed request for a team May 28, 2025 02:34
@solracsf solracsf added this to the Nextcloud 32 milestone May 28, 2025
@xlejo xlejo force-pushed the fix/files_versions/undefined_restored branch from 7d7f912 to c1bf032 Compare May 29, 2025 01:03
@skjnldsv skjnldsv force-pushed the fix/files_versions/undefined_restored branch from c1bf032 to 95975ab Compare May 29, 2025 10:08
@skjnldsv
Copy link
Member

Thanks for the PR @xlejo !

I renamed your commit with a proper [conventional commit] (https://www.conventionalcommits.org/en/v1.0.0/#summary), please adjust next time 😉

@skjnldsv skjnldsv force-pushed the fix/files_versions/undefined_restored branch from 95975ab to d33512f Compare May 29, 2025 10:08
@skjnldsv skjnldsv requested review from susnux and artonge May 29, 2025 10:09
@skjnldsv skjnldsv force-pushed the fix/files_versions/undefined_restored branch from d33512f to ab11868 Compare May 29, 2025 10:10
Signed-off-by: skjnldsv <[email protected]>
@skjnldsv skjnldsv requested a review from a team as a code owner May 29, 2025 10:12
@skjnldsv
Copy link
Member

/backport to stable30

@skjnldsv
Copy link
Member

/backport to stable31

@skjnldsv skjnldsv merged commit cdcfefc into nextcloud:master May 29, 2025
109 of 112 checks passed
Copy link

welcome bot commented May 29, 2025

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

@skjnldsv

This comment was marked as resolved.

This comment was marked as resolved.

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish feature: versions and removed 3. to review Waiting for reviews feature: versions labels May 29, 2025
@skjnldsv
Copy link
Member

/backport ab11868 to stable30

This comment was marked as resolved.

Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request feature: versions feedback-requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: "undefined restored" when restoring a previous version of a file
4 participants