-
-
Notifications
You must be signed in to change notification settings - Fork 4.3k
feat(core): Add option to disable creating an admin user when installing #53212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 Makes sense because if you have a bad hoster without occ access you might get locked out with misconfiguration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You messed up the cli options.
Just add a flag to disable admin creation, do not change behavior of --admin-user and --admin-pass.
43caeb5
to
0a9fb0f
Compare
0a9fb0f
to
c4034b0
Compare
@come-nc I reverted some of the changes that were not necessary anymore. I did the casting because in a previous version I also ensured that no admin-user, admin-pass and admin-email values are passed if --disable-admin-user was passed |
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
c4034b0
to
d11d5b7
Compare
…loud >= 32 With nextcloud/server#53212 it is not longer necessary to specify a username and password for an initial admin account during installation.
…loud >= 32 With nextcloud/server#53212 it is not longer necessary to specify a username and password for an initial admin account during installation.
Summary
When using non-database backends it can be annoying being forced to create an admin user during the installation process. Admin users can still be created through LDAP, OIDC and so on, so it's really not necessary to have a user with a database backend. Having to create this admin user is an additional burden since a password needs to be set and it should neither be simple nor random.
I did not add this option to the web installer because I believe for a lot of people using the web installer it's the only way they are able to install Nextcloud (due to technical restrictions not abilities). Enabling this option would result in a "bricked" instance for them since there is no way they could create a user after installation in order to login.
Checklist