Skip to content

fix: Do not enable applications which are not installed yet #53352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 5, 2025

Conversation

come-nc
Copy link
Contributor

@come-nc come-nc commented Jun 5, 2025

Summary

It was previously possible for an application to be enabled but not installed, if this application is shipped and disabled by default, and enabled through the provisioning_api application.
This was the case of the testing application in integration tests, creating weird behaviors.

Checklist

@come-nc come-nc added this to the Nextcloud 32 milestone Jun 5, 2025
@come-nc come-nc self-assigned this Jun 5, 2025
@come-nc come-nc added the 3. to review Waiting for reviews label Jun 5, 2025
@come-nc come-nc requested a review from a team as a code owner June 5, 2025 13:33
@come-nc come-nc requested review from icewind1991, artonge and sorbaugh and removed request for a team June 5, 2025 13:33
@come-nc come-nc force-pushed the fix/install-app-before-enable branch from f50b954 to bf340a5 Compare June 5, 2025 13:39
This avoids spamming the appstore server and getting banned from CI runs

Signed-off-by: Côme Chilliet <[email protected]>
@come-nc come-nc force-pushed the fix/install-app-before-enable branch from fd971f1 to c85f7ea Compare June 5, 2025 15:03
@come-nc come-nc merged commit 5488f7e into master Jun 5, 2025
192 checks passed
@come-nc come-nc deleted the fix/install-app-before-enable branch June 5, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants