Skip to content

fix(403): Make design consistent with 404 + add default hint #53402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 10, 2025

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Jun 8, 2025

Summary

  • Adds a default hint message (consistent with 404)
  • Adds an icon (consistent with 404 handler)
  • Adds box around main content (consistent with 404 handler)
  • Fixes an HTML syntax bug that was causing the footer to appear immediately after the error

After:

image

And, for comparison, the 404 page already looks like this:

image

Before:

image

TODO

  • ...

Checklist

@joshtrichards joshtrichards added this to the Nextcloud 32 milestone Jun 8, 2025
@joshtrichards joshtrichards requested a review from a team as a code owner June 8, 2025 18:40
@joshtrichards joshtrichards requested review from nfebe and skjnldsv and removed request for a team June 8, 2025 18:40
@joshtrichards joshtrichards requested a review from come-nc June 8, 2025 18:40
@joshtrichards joshtrichards added design Design, UI, UX, etc. 3. to review Waiting for reviews feature: authentication labels Jun 8, 2025
Copy link
Contributor

@susnux susnux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look good

@susnux susnux requested review from marcoambrosini and removed request for marcelklehr June 9, 2025 15:40
@AndyScherzinger AndyScherzinger merged commit fadda8c into master Jun 10, 2025
206 of 211 checks passed
@AndyScherzinger AndyScherzinger deleted the jtr-fix-403-design branch June 10, 2025 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews bug design Design, UI, UX, etc. feature: authentication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Access forbidden" (HTTP 403) page displayed as dead end
3 participants