feat(log): add opt-in session ID logging #53506
Open
+19
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christoph Wurst <[email protected]>
ChristophWurst
requested review from
Altahrim,
artonge and
provokateurin
and removed request for
a team
8 tasks
|
/backport to stable31 |
|
/backport to stable30 |
provokateurin
approved these changes
Jun 16, 2025
artonge
reviewed
Jun 18, 2025
| @@ -170,6 +172,13 @@ public function log(int $level, string $message, array $context = []): void { | |||
| if (!$hasBacktrace && $logBacktrace) { | |||
| $entry['backtrace'] = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS); | |||
| } | |||
| if ($this->config->getValue('log.sessionId', false)) { | |||
| try { | |||
| $entry['sessionId'] = \OCP\Server::get(ISession::class)->getId(); | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Optionally allow admins to enable logging of session IDs. This allows to see when a new session is started for a user. That information is not trackable right now.
TODO
Checklist