fix(notifications): Allow sessions to mark themselves as inactive#10544
Merged
nickvergessen merged 2 commits intomasterfrom Sep 26, 2023
Merged
fix(notifications): Allow sessions to mark themselves as inactive#10544nickvergessen merged 2 commits intomasterfrom
nickvergessen merged 2 commits intomasterfrom
Conversation
nickvergessen
added
3. to review
enhancement
feature: chat 💬
Signed-off-by: Joas Schilling <coding@schilljs.com>
nickvergessen
force-pushed
the
bugfix/1575/notification-with-inactive-tabs
branch
from
deb93b2 to
2e7b140
Compare
nickvergessen
commented
Sep 25, 2023
nickvergessen
commented
Sep 25, 2023
nickvergessen
commented
Sep 25, 2023
nickvergessen
commented
Sep 25, 2023
nickvergessen
commented
Sep 26, 2023
Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>
Antreesy
force-pushed
the
bugfix/1575/notification-with-inactive-tabs
branch
from
d10e09e to
d833dd3
Compare
nickvergessen
commented
Sep 26, 2023
Member
Author
nickvergessen
left a comment
nickvergessen
left a comment
There was a problem hiding this comment.
Frontend code seems to work 👍🏼
Antreesy
approved these changes
Sep 26, 2023
Contributor
Antreesy
left a comment
Antreesy
left a comment
There was a problem hiding this comment.
Backend also works fine
nickvergessen
deleted the
bugfix/1575/notification-with-inactive-tabs
branch
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
☑️ Resolves
🏁 Checklist
docs/has been updated or is not required