Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow users to recieve notifications when a chat is open in background #10642

Closed
wants to merge 3 commits into from

Conversation

poiNt3D
Copy link

@poiNt3D poiNt3D commented Oct 5, 2023

☑️ Resolves #10641

🏁 Checklist

[X] 🌏 Tested with Chrome, Firefox and Safari or should not be risky to browser differences
[]🖌️ Design was reviewed, approved or inspired by the design team
[]⛑️ Tests are included or not possible
[X]📗 User documentation in https://github.com/nextcloud/documentation/tree/master/user_manual/talk has been updated or is not required

Signed-off-by: poiNt3D <[email protected]>
removed code preventing online users to be notified

Signed-off-by: poiNt3D <[email protected]>
@poiNt3D
Copy link
Author

poiNt3D commented Oct 5, 2023

Sorry, I don't really know how to fill the template correctly. The changes are pretty small, but it solves the issue.

@nickvergessen
Copy link
Member

nickvergessen commented Oct 6, 2023

Thanks for the work and efforts. However it's unluckily not this easy.
However we solved it already for the next version. See #1575 (comment) for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications should consider message read status
2 participants