-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(call): add option to enable blur background by default for all c… #13490
Conversation
I don't recall what we store in the local storage so far. its a "type" (string?) and in case type is image we also store the "name of the image" (string?) or what do we store? |
We store all 3 in the backend in the future? |
That's a better behavior IMO (not reliant on browser). Will it stay per conversation level or we change to one setting for all conversations? |
The API stored config has to be 1 for all, otherwise we save too many preferences? |
e5285e5
to
fd3a036
Compare
fd3a036
to
4af6dfc
Compare
566cf69
to
a0d7666
Compare
bd360b6
to
43a27db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Acceptable
…onversations Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
8334931
to
e47f4ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perfecto
Please rebase, remove composer files and re-split into commits (backend -> openapi -> frontend?)
Signed-off-by: DorraJaouad <[email protected]>
…evel virtual background Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
Signed-off-by: DorraJaouad <[email protected]>
e47f4ae
to
9ea1f70
Compare
/backport to stable30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PHP code is fine!
…onversations
☑️ Resolves
It's default settings, meaning that if this config is on, the blur effect will apply automatically and it's up to user to change it before joining the call.
🖌️ UI Checklist
🖼️ Screenshots / Screencasts
🚧 Tasks
🏁 Checklist